Fixed path in logo customization section #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this PR it is necessary to backport to the 4.3-7.16 branches and 4.3-1.2-wdz? |
AlexRuiz7
suggested changes
Jul 22, 2022
gdiazlo
changed the title
gdiazlo
changed the title
gdiazlo
reviewed
Jul 26, 2022
…tps://github.com/wazuh/wazuh-kibana-app into Fix/4337-Wrong-path-for-Wazuh-logo-Customization
Desvelao
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
review
Code ✔️
Test ✔️
Screenshots
# ------------------------------ wazuh-logo-customization -------------------------------
#
#Define the name of the app logo saved in the path /plugins/wazuh/public/assets/
#customization.logo.app: ''
#
#Define the name of the sidebar logo saved in the path /plugins/wazuh/public/assets/
#customization.logo.sidebar: ''
#
#Define the name of the health-check logo saved in the path /plugins/wazuh/public/assets/
#customization.logo.healthcheck: ''
#
#Define the name of the reports logo (.png) saved in the path /plugins/wazuh/public/assets/
#customization.logo.reports: ''
github-actions bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
* change of path * CHANGELOG * new constant * update test * updated constant name * updated constant name * Update CHANGELOG.md * changelog: add PR entry Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 05598cf)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-1.2-wzd 4.3-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.3-1.2-wzd
# Create a new branch
git switch --create backport-4352-to-4.3-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 05598cf83a70221e8203b2b41afd43d61813fee6
# Push it to GitHub
git push --set-upstream origin backport-4352-to-4.3-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-1.2-wzdThen, create a pull request where the |
Desvelao
pushed a commit
that referenced
this pull request
Jul 26, 2022
Fixed path in logo customization section (#4352) * change of path * CHANGELOG * new constant * update test * updated constant name * updated constant name * Update CHANGELOG.md * changelog: add PR entry Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 05598cf) Co-authored-by: Chantal Belén kelm <99441266+chantal-kelm@users.noreply.github.com>
|
Desvelao
added a commit
that referenced
this pull request
Jul 26, 2022
* change of path * CHANGELOG * new constant * update test * updated constant name * updated constant name * Update CHANGELOG.md * changelog: add PR entry Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>
Integrated in b35023c. |
Desvelao
added a commit
that referenced
this pull request
Jul 26, 2022
* change of path * CHANGELOG * new constant * update test * updated constant name * updated constant name * Update CHANGELOG.md * changelog: add PR entry Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new constant has been created in the
common/constants.tsfile and used in all necessary places